Apply bits of the cookie settings PR one by one#140
Merged
Conversation
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Signed-off-by: Xe Iaso <me@xeiaso.net>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR progressively applies fixes from #135 to update cookie handling and improve browser testing in CI. The key changes include:
- Converting ClearCookie to a Server method that applies the cookie domain and partitioned flag.
- Refactoring tests to load policies separately and improve error handling and browser test retries.
- Adding CLI flags and updating CI workflows to support the new cookie settings.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/http.go | Updated ClearCookie to include Domain from server options |
| lib/anubis_test.go | Refactored test helpers and added validations for cookie domain and partitioning |
| lib/anubis.go | Added cookie settings to Options and applied them when creating cookies |
| internal/test/playwright_test.go | Modified browser tests to retry actions and return errors gracefully |
| docs/docs/CHANGELOG.md | Updated changelog with new cookie settings and CI fixes |
| cmd/anubis/main.go | Introduced CLI flags for cookie domain and partitioned flag |
| .github/workflows/go.yml | Added playwright browser installation and enabled verbose testing |
Files not reviewed (2)
- docs/docs/admin/installation.mdx: Language not supported
- internal/test/var/.gitignore: Language not supported
Xe
force-pushed
the
Xe/cookie-settings-one-by-one
branch
from
1135694 to
e095554
Compare
JasonLovesDoggo
pushed a commit
to JasonLovesDoggo/anubis
that referenced
this pull request
Jun 17, 2025
Enables uses to change the cookie domain and partitioned flags. Signed-off-by: Xe Iaso <me@xeiaso.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a suffering PR where I apply all of the fixes in #135 in order to see what breaks it. The browser smoke test would have caught this, so I am fixing this in CI too.